Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a380x/nd): Update ND and VD Range Change Messages #9739

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix(a380x/nd): Update ND and VD Range Change Messages #9739

wants to merge 6 commits into from

Conversation

MrJigs7
Copy link
Contributor

@MrJigs7 MrJigs7 commented Jan 9, 2025 •
edited
Loading

Fixes #9473

Summary of Changes

Updated Range Change flag to use a prop and defined relevant values for both A32NX and A380X
Added CSS class for A380X as ND RANGE CHANGE message is different font size and position
Added VD Range Change message

Screenshots (if necessary)

A320 Range Change
A320RangeChange
A380 ND Range Change
A380NDRangeChange
A380 VD Range Change
A380VDRangeChange
A320 Mode Change
A320ModeChange
A380 Mode Change
A380NDModeChange

References

A320RangeChangeReference
A380NDRangeChangeRef1
VDRangeChangeRef1
VDRangeChangeRef2
A380NDModeChangeRef1
A380VDRangeChangeRef3

Additional context

Discord username (if different from GitHub): MrJigs.

Testing instructions

  1. Load A380X in powered state
  2. Change EFIS range setting
  3. Observe ND for correct messages displayed on both ND and VD
  4. Load A32NX in powered state
  5. Observe no changes

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@MrJigs7 MrJigs7 marked this pull request as draft January 9, 2025 23:49
@MrJigs7
Copy link
Contributor Author

MrJigs7 commented Jan 9, 2025

Could someone possibly assist with some guidance on the VD Range Change part of this PR? Currently the text is always visible even though I set a initial defaul value of 0, assuming that would be falsy, before I try to capture the ndRangeSetting change event.

@BravoMike99
Copy link
Contributor

BravoMike99 commented Jan 10, 2025 •
edited
Loading

Could someone possibly assist with some guidance on the VD Range Change part of this PR? Currently the text is always visible even though I set a initial defaul value of 0, assuming that would be falsy, before I try to capture the ndRangeSetting change event.

You probably need to use a boolean to drive the visibility of the message and whenever the range is changed, set that to true and after a timeout set it to false. You can take the logic of the message on the ND for some inspiration as it behaves like this.
Another possibility would to listen for the same event as the ND range change
Btw if you'd like you could also change the MODE change message on this PR, it's ND MODE CHANGE on the A380.

@MrJigs7 MrJigs7 marked this pull request as ready for review January 13, 2025 13:13
@MrJigs7
Copy link
Contributor Author

MrJigs7 commented Jan 13, 2025

Ready for review now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Quality Assurance
Status: 🟡 Code Review: Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ND range change messages are incorrect
2 participants
@MrJigs7 @BravoMike99